Skip to content

Conversation

mo8it
Copy link

@mo8it mo8it commented Jun 24, 2022

Fix issues like #2001

See comment #2001 (comment)

@Ryooooooga
Copy link
Contributor

Expanding ~ is the responsibility of the shell, not lazygit.

The original issue was caused by an incorrect configuration (it should be "$HOME/.config/lazygit/config.yml", not "~/.config/lazygit/config.yml"), and it is a deviation from common UNIX program behavior for lazygit to expand ~.

@mo8it
Copy link
Author

mo8it commented Jun 27, 2022

But it does not cause any harm, right?

@Ryooooooga
Copy link
Contributor

We should not do what we do not have to do.

@mo8it
Copy link
Author

mo8it commented Jun 28, 2022

Alright, you decide.
But if you don't want to include it, please add a small hint to the docs to the config paths :)

I have no problem with closing the PR.

Thanks for the awesome software anyway ❤️

@jesseduffield
Copy link
Owner

I agree with @Ryooooooga: the less complexity we can have in lazygit, the better. With that said, if over time we see others running into this same problem, we can reconsider. Thanks for raising the PR at any rate @mo8it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants