Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - Adds a null check before building TrackLoveRequest (fix #57) #58

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

jesseward
Copy link
Owner

@jesseward jesseward commented Jan 9, 2024

Summary

As reported in #57 , attempts to "love" a track that does not include ID3 metadata, the plugin crashes with an unhandled exception (System.InvalidOperationException: Sequence contains no elements).

This change adds a null check before building the TrackLoveRequest and returns early if required metadata is not present.

This change also

  • cleans up the devcontainer to add sshd
  • Adds an additional mp3 file without id3 metadata
  • Moves example.mp3 test data to appropriate directory structure, for rich metadata scraping when working in the devcontainer.
  • fix logging string formatting within LoveTrack(..)

Related

@jesseward jesseward marked this pull request as ready for review January 9, 2024 16:31
@jesseward jesseward merged commit b808f2d into master Jan 9, 2024
1 check passed
@jesseward jesseward deleted the jesseward/issue-57 branch January 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin crashes Jellyfin when trying to sync favourited track that has no metadata
1 participant