-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove providesModuleNodeModules
from Jest.
#8535
Conversation
I'll let you guys merge this on your own time whenever it is convenient for you. I don't wanna conflict with whatever may be happening on master right now :) |
F I N A L L Y ! 🎉🎉🎉🎉🎉 |
This breaking, but I think we should land it when we're starting to break things for 25. Not sure if disabling the react native test or trying to do some clever yarn tricks to get old dependencies in is the correct solution? |
I fixed the failures from the initial version of this PR but didn't do anything with the react-native example. I'll leave it to you to decide on the right timing for landing this and what to do with the test. If you temporarily exclude the react-native example, I think that's fine. |
I've rebased this and bumped RN from 0.58 to 0.60. Hopefully it passes CI 🙂 |
@SimenB Haste is fully removed in RN 0.61, the RC should be released soon, maybe even today. |
We should be fine with RC once it's out. Expo is always at least 1 release behind for stability reasons + some time to update their modules and the fork I guess. Fun fact – most of the Haste removal work came out from Expo 🙂 |
Yep RC should be fine for testing purposes here. |
ff9269b
to
cf24070
Compare
RC is out, lemme try to rebase EDIT: Ergh tag is out, but it's not published. https://github.com/facebook/react-native/releases/tag/v0.61.0-rc.0 |
This comment has been minimized.
This comment has been minimized.
As discussed privately, I think we should hold off merging this at least one major - if we do not we will break compatibility with all RN releases prior to 0.61. |
We've upgraded RN on master now, so I've rebased this. In theory we're unblocked, and only need to wait until we start landing breaking changes to release |
Codecov Report
@@ Coverage Diff @@
## master #8535 +/- ##
=======================================
Coverage 65.07% 65.07%
=======================================
Files 286 286
Lines 12144 12144
Branches 3010 3010
=======================================
Hits 7903 7903
Misses 3605 3605
Partials 636 636 Continue to review full report at Codecov.
|
Hi, wanna clarify that this PR means that Jest 26 cannot be used for RN < 0.61 right? Thanks |
Correct |
This option seems to be a work around for an open issue regarding getting jest to run tests in directories nested in folders named Unless I'm missing something this is technically breaking for those users as well... :/ |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
With the removal of haste from
react-native
, we finally do not needprovidesModuleNodeModules
in either Jest or Metro any longer. This is the PR that removes this feature from Jest and a corresponding change will be merged to Metro soon.This was one of my least favorite configuration options and the added complexity (see the whitelist in
jest-haste-map
) was annoying to deal with. No more!Test plan
Ran the tests via
yarn jest