Skip to content

Fix template create when ssh key is not setup #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Fix template create when ssh key is not setup #1074

merged 1 commit into from
Jun 1, 2023

Conversation

LucilleH
Copy link
Collaborator

@LucilleH LucilleH commented Jun 1, 2023

Summary

For users and Dockerfile that has no ssh key setup, we need to clone by https

How was it tested?

devbox run build
devbox create --template apache

@LucilleH LucilleH requested a review from mikeland73 June 1, 2023 03:35
mikeland73
mikeland73 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this works without auth because repo is public?

@LucilleH
Copy link
Collaborator Author

LucilleH commented Jun 1, 2023

I guess this works without auth because repo is public?

yes

@LucilleH LucilleH merged commit 59a29ae into main Jun 1, 2023
@LucilleH LucilleH deleted the lucille--fix-template-create branch June 1, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucilleH @mikeland73