[trace] Add trace for Devbox methods #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is still working in progress. Is it a good idea to trace them all? @savil @mikeland86 |
hezhizhen
changed the title
|
@gcurtis do you have thoughts on this? I know you'd added the initial tracing infra, and dashboards. My concern would be that adding to each method may get overwhelming to track in the dashboards, but i'm not sure where to look for them. |
gcurtis
reviewed
Jun 8, 2023
hezhizhen
force-pushed
the
trace
branch
3 times, most recently
from
ae475fa to
8682745
Compare
|
The rest methods are so simple that I don't think it's necessary to add trace. PTAL @gcurtis |
hezhizhen
force-pushed
the
trace
branch
5 times, most recently
from
457eec2 to
9511ec1
Compare
gcurtis
approved these changes
Jun 15, 2023
internal/impl/update.go
Outdated
Comment on lines
4
to
6
| // Copyright 2023 Jetpack Technologies Inc and contributors. All rights reserved. | ||
| // Use of this source code is governed by the license in the LICENSE file. | ||
|
|
There was a problem hiding this comment.
Yeah. That's weird. I removed it.
|
@hezhizhen thanks! if you could resolve the conflcts, I can help merge. |
Done. PTAL @savil |
savil
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ctxparameter for most Devbox methodsHow was it tested?