[update] UX fixes to update path #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jun 9, 2023
mohsenari
approved these changes
Jun 9, 2023
| _, err := Open(&devopt.Opts{ | ||
| Dir: baseDir, | ||
| Writer: os.Stdout, | ||
| ShowWarnings: true, |
There was a problem hiding this comment.
We don't need ignoreWarnings: false for tests?
mikeland73
added a commit
that referenced
this pull request
Jun 19, 2023
## Summary We can't update flakes yet, so show error, but continue. fixes bug introduced in #1129 ## How was it tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes/refactors:
ShowWarnings->IgnoreWarningsbecause we ignore in the vast majority of cases. Fixed a few cases that were accidentally ignored.How was it tested?
devbox global updateand ran it.Repeated process for non-global as well.