Skip to content

[searcher] Add SearchOption and handle host error #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[searcher] Add SearchOption and handle host error #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/searcher/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func Client() *client {
}
}

func (c *client) Search(query string, options ...func() string) (*SearchResult, error) {
func (c *client) Search(query string, options ...SearchOption) (*SearchResult, error) {
if query == "" {
return nil, fmt.Errorf("query should not be empty")
}
Expand All @@ -50,7 +50,10 @@ func (c *client) Search(query string, options ...func() string) (*SearchResult,
return execSearch(searchURL)
}

func WithVersion(version string) func() string {
// SearchOption returns a string for query to be appended to the endpoint
type SearchOption func() string

func WithVersion(version string) SearchOption {
return func() string {
return "&v=" + url.QueryEscape(version)
}
Expand Down