[cleanup] plansdk #1188
Merged
[cleanup] plansdk #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `devbox plan` command. This is no longer used anywhere. - this means we can remove `devbox.ShellPlan` from the public interface - Move `plansdk.Analyzer` to `initrec/analyzer/analyzer.go`. It is exclusively used in `initrec/recommenders`. - Move plansdk/version to analyzer/version. It is also exclusively used in `initrec/recommenders`.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
LucilleH
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
devbox plancommand. This is no longer used anywhere.devbox.ShellPlanfrom the public interfaceplansdk.Analyzertoinitrec/analyzer/analyzer.go. It is exclusively used ininitrec/recommenders.initrec/recommenders.My next PR will likely refactor
plansdkfurther since it now has two unrelated structs:FlakeInputandNixpkgsInfo.How was it tested?
opened
devbox shellinexamples/development/go/hello-world/.go run .testscripts should pass