[CLI] Changed default nix bash to bashInteractive #1223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
shellPath()
function where we decide which type of shell to use when dropping user in devbox shell, if we can't figure out the shell, we drop the user in the defaultbash
that nix installs in store. But this bash doesn't handle arrow keys and keyboard combinations very well, so it creates a frustrating experience for users (including pure shell users).bashInteractive
package has all these capabilities and makes the experience better for a 'default' shell.So this PR changes this:
nix eval <bash>
to get store path and use to create default shellto this:
nix eval <bashInteractive>
to get store pathAddresses #1193
How was it tested?
OR