Skip to content

call nix.System directly from lock.lockfile #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2023
Merged

call nix.System directly from lock.lockfile #1245

merged 1 commit into from
Jul 1, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Jun 30, 2023

Summary

Removes the workaround hack I had made

How was it tested?

compiles

This was referenced Jun 30, 2023
Merged
Merged
Closed
@savil Graphite App
Copy link
Collaborator Author

savil commented Jun 30, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil mentioned this pull request Jun 30, 2023
Closed
@savil savil requested review from mikeland73 and mohsenari June 30, 2023 23:53
Base automatically changed from savil/mv-devpkg to main June 30, 2023 23:54
@savil savil force-pushed the savil/lock-system-2 branch from fe6804d to 94f4835 Compare June 30, 2023 23:55
@savil savil merged commit 4e672c5 into main Jul 1, 2023
@savil savil deleted the savil/lock-system-2 branch July 1, 2023 00:00
@savil savil mentioned this pull request Jul 1, 2023
Merged
savil added a commit that referenced this pull request Jul 1, 2023
@savil
move nix.System call inside featureflag.RemoveNixpkgs if-condition (#…
ab2e8a7 
…1247)

## Summary

I'm not yet entirely sure why, but #1245 led to some testscript error.
For now, I'm hiding the nix.System call inside the feature flag's
if-condition
to get the testscripts status to green again on `main`.

## How was it tested?

testscripts should pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

@mohsenari mohsenari Awaiting requested review from mohsenari

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savil @mikeland73