Skip to content

[plugins] Implements github plugins #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2023
Merged

[plugins] Implements github plugins #1281

merged 3 commits into from
Jul 19, 2023

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Jul 18, 2023 •
edited
Loading

Summary

This implements github plugins. They use the following syntax in devbox.json:

"include": [
    "github:jetpack-io/devbox-plugin-example/6ea0ef9e12ab58dbbb145ca8f3a465611cb603a9"
  ]

revision is optional and defaults to master/main.

Repos must have devbox.json at top level.

TODO:

  • Better error message for missing devbox.json and other files.
  • Add to lockfile? The are currently locked using optional revision
  • Updates: They are currently don't update unless change is made that busts local.lock cache.

How was it tested?

image

@mikeland73 mikeland73 requested review from loreto, Lagoja and ipince July 18, 2023 00:09
loreto
loreto approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeland73 mikeland73 merged commit dd41255 into main Jul 19, 2023
@mikeland73 mikeland73 deleted the landau/github-plugins branch July 19, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loreto loreto loreto approved these changes

@Lagoja Lagoja Awaiting requested review from Lagoja

@ipince ipince Awaiting requested review from ipince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @loreto