[update] Add simple unit test for lockfile merge logic #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jul 26, 2023
ipince
force-pushed
the
rodrigo/update-test
branch
from
12c26f2 to
b3c6b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm sorry if this steps a bit on your toes :( . I just figured I wanted some unit test before I made the changes to the merging logic, and noticed that if I just refactored a function a little bit, then we could add some unit tests easily at the function level.
I just added 1 unit test here to demonstrate, and will add more later as I implement the bugfix.
How was it tested?
Unit tests