[remove nixpkgs] Remove CAPath, and only enable for nix >= 2.17 #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to restrict the feature to nix 2.17+, because it enables pure mode nix
when using just
fromPath
inbuiltins.fetchClosure
.This greatly simplifies the
devbox.lock
issues with caPath, and will improve the UX.This Remove Nixpkgs feature is most beneficial to new users who have not downloaded the nixpkgs they need. These users are most likely to have the latest nix installed for them, so I think restricting to nix >= 2.17 is an acceptable tradeoff.
How was it tested?
did a sanity test on x86-darwin.
need to test betteron a "supported system" where nix >= 2.17:examples/development/python/pip
, diddevbox shell
. Since we have system-info forpython
and notpip
, the generatedflake.nix
looked like this: