[DotNetPlanner] shell and build for C# and F# #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
savil
force-pushed
the
savil/fsharp-planner
branch
2 times, most recently
from
f8d35e5 to
3de30ee
Compare
savil
commented
Sep 16, 2022
cuecfg/cuecfg.go
Outdated
| @@ -52,7 +52,7 @@ func Unmarshal(data []byte, extension string, valuePtr any) error { | |||
| return errors.WithStack(err) | |||
| } | |||
| return nil | |||
| case ".xml", ".csproj": | |||
| case ".xml", ".csproj", ".fsproj": | |||
There was a problem hiding this comment.
I don't love needing to hard code .csproj and .fsproj in this package. It is needed because the cuecfg.ParseFiles function derives the extension from the filename, and so there is no means of indicating what extension to use.
An alternative idea is to introduce cuecfg.ParseFilesForExtension(filepath string, ext string) and I can call it as cuecfg.ParseFiles(projectPath, ".xml")
savil
force-pushed
the
savil/fsharp-planner
branch
from
3de30ee to
fd59c61
Compare
- rename csharp package to dotnet - Add support for `.fsproj` extension to enable support for F# language.
savil
force-pushed
the
savil/fsharp-planner
branch
from
fd59c61 to
cbfbe49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.fsprojextension to enable support for F# language.How was it tested?
Added a testdata case for fsharp-hello-world that does version checking....