Skip to content

Conversation

savil
Copy link
Collaborator

@savil savil commented Sep 16, 2022

Summary

In .Net, the package manager is called NuGet. https://www.nuget.org

dotnet restore is the equivalent of pip install. I add this to the InstallStage.

And ensure we do not do restore during dotnet publish and dotnet run (which it implicitly does otherwise)

How was it tested?

addded testcase that adds a package for json: https://www.nuget.org/packages/Newtonsoft.Json/

> devbox build
> docker run devbox
serialized json for csharp_10_dotnet_6_with_package.Product is {"Name":"Apple","Expiry":"2008-12-28T00:00:00","Sizes":["Small"]}

Copy link
Collaborator Author

savil commented Sep 16, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil force-pushed the savil/dotnet-restore branch from 55d1775 to 3421b4f Compare September 16, 2022 23:52
@savil savil force-pushed the savil/dotnet-restore branch from 3421b4f to 5da3f66 Compare September 16, 2022 23:53
@savil savil marked this pull request as ready for review September 16, 2022 23:54
@savil savil force-pushed the savil/dotnet-restore branch from 5da3f66 to 04db4b5 Compare September 20, 2022 04:25
Copy link
Collaborator

@gcurtis gcurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My C# is a bit rusty, but from what I can remember everything looks good to me!

@savil savil merged commit 494a276 into main Sep 20, 2022
@savil savil deleted the savil/dotnet-restore branch September 20, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants