[pip] Add pip support (via venv) DEV-1146 #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx fails to start when the temporary directories in shell-helper-nginx.conf don't exist yet. Specifically, the `cache` subdirectory needs to be created under the temp directory. To fix this: 1. Use os.TempDir() to ensure we use the OS-specific temporary directory (which on macOS isn't `/tmp`). 2. Don't use a `cache` subdirectory so we don't need to worry about the directory existing.
savil
reviewed
Sep 21, 2022
Comment on lines
+17
to
+19
| // ImportError: libstdc++.so.6: cannot open shared object file: No such file or directory | ||
| // possible solution is to set $LD_LIBRARY_PATH | ||
| // https://nixos.wiki/wiki/Packaging/Quirks_and_Caveats |
There was a problem hiding this comment.
Try adding gcc or binutils nix package when building with pandas.
| return nil | ||
| } | ||
|
|
||
| return usererr.New( |
gcurtis
approved these changes
Sep 23, 2022
Comment on lines
74
to
75
| python -m venv %[1]s; | ||
| source %[2]s;`) |
There was a problem hiding this comment.
Just in case srcDir has spaces:
Suggested change
| python -m venv %[1]s; | |
| source %[2]s;`) | |
| python -m venv "%[1]s"; | |
| source "%[2]s";`) |
devbox_test.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestDevbox(t *testing.T) { | |||
| os.Setenv("TMPDIR", "/tmp") | |||
There was a problem hiding this comment.
If you use t.Setenv it'll automatically restore the original value and guard against changing the value in parallel tests.
It might also be worth checking that /tmp exists before using it so we can provide a helpful error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is stacked on #105. Please review that one first.
Adds basic pip support.
Does not yet libraries with native extensions like
pandasbut there's a plan for that.How was it tested?
devbox shell.devbox build