Skip to content

[Script Exit on Error] enable feature flag, and add stability advice to CICD docs #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[Script Exit on Error] enable feature flag, and add stability advice to CICD docs #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb840c
[Script Exit on Error] enable feature flag, and add stability advice …
savil Sep 14, 2023
f8cc859
lint fix
savil Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/app/docs/continuous_integration/github_action.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,5 @@ jobs:
## Configuring the Action

See the [GitHub Marketplace page](https://github.com/marketplace/actions/devbox-installer) for the latest configuration settings and an example.

For stability over new features and bug fixes, consider pinning `devbox-version`. Remember to update this pinned version when you update your local Devbox via `devbox version update`.
6 changes: 6 additions & 0 deletions internal/boxcli/featureflag/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ type feature struct {

var features = map[string]*feature{}

// Prevent lint complaining about unused function
//
//nolint:unparam
func disable(name string) *feature {
if features[name] == nil {
features[name] = &feature{name: name}
Expand All @@ -27,6 +30,9 @@ func disable(name string) *feature {
return features[name]
}

// Prevent lint complaining about unused function
//
//nolint:unparam
func enable(name string) *feature {
if features[name] == nil {
features[name] = &feature{name: name}
Expand Down
2 changes: 1 addition & 1 deletion internal/boxcli/featureflag/script_exit_on_error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ package featureflag

// ScriptExitOnError controls whether scripts defined in devbox.json
// and executed via `devbox run` should exit if any command within them errors.
var ScriptExitOnError = disable("SCRIPT_EXIT_ON_ERROR")
var ScriptExitOnError = enable("SCRIPT_EXIT_ON_ERROR")