Skip to content

[script set -e] enable feature flag #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[script set -e] enable feature flag #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/boxcli/featureflag/script_exit_on_error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ package featureflag

// ScriptExitOnError controls whether scripts defined in devbox.json
// and executed via `devbox run` should exit if any command within them errors.
var ScriptExitOnError = disable("SCRIPT_EXIT_ON_ERROR")
var ScriptExitOnError = enable("SCRIPT_EXIT_ON_ERROR")
4 changes: 1 addition & 3 deletions internal/shellgen/scripts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ func WriteScriptFile(devbox devboxer, name, body string) (err error) {
defer script.Close() // best effort: close file

if featureflag.ScriptExitOnError.Enabled() {
// NOTE: Devbox scripts will run using `sh` for consistency.
// However, we need to disable this for `fish` shell if/when we allow this for init_hooks,
// since init_hooks run in the host shell, and not `sh`.
// NOTE: Devbox scripts run using `sh` for consistency.
body = fmt.Sprintf("set -e\n\n%s", body)
}
_, err = script.WriteString(body)
Expand Down