Skip to content

[perf UX] add spinner to print-dev-env output #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[perf UX] add spinner to print-dev-env output #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe7790
[perf UX] add spinner to print-dev-env output
savil Oct 10, 2023
cf39b71
change to Computing the Devbox Environment
savil Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/impl/devbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ import (
"strconv"
"strings"
"text/tabwriter"
"time"

"github.com/briandowns/spinner"
"github.com/pkg/errors"
"github.com/samber/lo"
"go.jetpack.io/devbox/internal/devpkg"
Expand Down Expand Up @@ -781,11 +783,22 @@ func (d *Devbox) computeNixEnv(ctx context.Context, usePrintDevEnvCache bool) (m
originalEnv := make(map[string]string, len(env))
maps.Copy(originalEnv, env)

var spinny *spinner.Spinner
if !usePrintDevEnvCache {
spinny = spinner.New(spinner.CharSets[11], 100*time.Millisecond, spinner.WithWriter(d.stderr))
spinny.FinalMSG = "✓ Computed the Devbox environment.\n"
spinny.Suffix = " Computing the Devbox environment...\n"
spinny.Start()
}

vaf, err := d.nix.PrintDevEnv(ctx, &nix.PrintDevEnvArgs{
FlakeDir: d.flakeDir(),
PrintDevEnvCachePath: d.nixPrintDevEnvCachePath(),
UsePrintDevEnvCache: usePrintDevEnvCache,
})
if spinny != nil {
spinny.Stop()
}
if err != nil {
return nil, err
}
Expand Down
1 change: 0 additions & 1 deletion internal/impl/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ func (d *Devbox) ensurePackagesAreInstalled(ctx context.Context, mode installMod
return err
}

fmt.Fprintf(d.stderr, "Recomputing the devbox environment.\n")
// Force print-dev-env cache to be recomputed.
nixEnv, err := d.computeNixEnv(ctx, false /*use cache*/)
if err != nil {
Expand Down