Update PostgreSQL example for cross-platform #1763
Merged
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jan 30, 2024
| ## Adding Postgres to your Shell | ||
|
|
||
| `devbox add postgresql glibcLocales`, or in your `devbox.json`, add | ||
| You can install the PostgreSQL server and client by running`devbox add postgresql`. In some Linux distributions, you may also need to add `glibcLocales`, which can be added using `devbox add glibcLocales -p x86_64-linux,aarch64-linux`. |
There was a problem hiding this comment.
nit: slight preference to use --platform instead of shorthand -p since this is documentation. Makes it more self-explanatory.
Signed-off-by: John Lago <750845+Lagoja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current PostgreSQL example doesn't work on MacOS because it attempts to install glibcLocales. This updates the example and documentation to only install glibcLocales on Linux
How was it tested?
CI/CD, run example locally