Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD] Add slack message when cli release is complete #1806

Merged
merged 10 commits into from
Feb 13, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

TSIA

How was it tested?

@Lagoja
Copy link
Contributor

Lagoja commented Feb 10, 2024

Does this only notify when the release completes successfully? I need a message on failure + cancellation as well, since that's the issue that causes me to miss releases

@mikeland73
Copy link
Contributor Author

@Lagoja now it does. It reports test failures/cancelations and also reports final release status (assuming tests did not fail or were canceled)

Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeland73 mikeland73 merged commit 464fb9e into main Feb 13, 2024
24 checks passed
@mikeland73 mikeland73 deleted the landau/add-slack-message branch February 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants