[nix-cache] Add ability to use nix cache with env var #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Mar 13, 2024
internal/devbox/bincache/bincache.go
Outdated
| // TODO: if user is logged in (or if we have token we can refresh) | ||
| // then we try to fetch the bincache URL from the API. | ||
|
|
||
| // DEVBOX_NIX_BINCACHE_URL seems like a friendlier name than "substituter" |
mikeland73
force-pushed
the
landau/nix-cache-use
branch
from
9107439 to
6f1e520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets up boilerplate to use nix cache and allows use via environment variable.
TODOs: (in follow ups)
How was it tested?
DEVBOX_NIX_BINCACHE_URI="s3://mike-test-nix-cache?region=us-west-2" devbox add hello