Skip to content

Update JSON schema for plugin v2 #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update JSON schema for plugin v2 #1898

merged 1 commit into from
Mar 14, 2024

Conversation

Lagoja
Copy link
Contributor

@Lagoja Lagoja commented Mar 14, 2024

Summary

Update JSON schema for Devbox Plugins

How was it tested?

@Lagoja Lagoja requested review from mikeland73 and savil March 14, 2024 21:31
mikeland73
mikeland73 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have 1 schema include the other? Ideally the plugin schema is the devbox.json plus a few other fields.

@Lagoja
Copy link
Contributor Author

Lagoja commented Mar 14, 2024

It looks like that's possible: https://json-schema.org/understanding-json-schema/structuring

Can we fix that after the release?

@Lagoja Lagoja merged commit ff7b1cb into main Mar 14, 2024
@Lagoja Lagoja deleted the jl/update-plugin-schema branch March 14, 2024 22:47
@mikeland73
Copy link
Contributor

Can we fix that after the release?

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

@savil savil Awaiting requested review from savil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lagoja @mikeland73