nixcache: improve auto-configuration of cache #2010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few issues with the current auto-configuration flow for private nix caches: - Track whether or not we've configured ~root/.aws/config in a separate state file in the user's home directory. This lets Devbox know if AWS has already been configured, even if it cannot read root's home directory. - If the user answers no to the sudo confirmation prompt, don't ask them again. This is so we don't pester the user every time they install a package. - Preserve XDG_STATE_HOME in sudo so that we write state files to the correct directory. - Append a timestamp to the ~root/.aws directory when we back it up. This allows multiple backups if the setup process is run more than once. The logic for saving state around whether or not the cache setup has already run lives in a new `setup` package. The `setup` package tracks when a task last ran, what version of Devbox it ran with, and if there was an error. This makes it easier to define tasks that only run once for a user or only occur after an upgrade.
mikeland73
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues with the current auto-configuration flow for private nix caches:
The logic for saving state around whether or not the cache setup has already run lives in a new
setuppackage. Thesetuppackage tracks when a task last ran, what version of Devbox it ran with, and if there was an error. This makes it easier to define tasks that only run once for a user or only occur after an upgrade.