patchpkg: lookPath helper to find nix binaries
#2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running inside a Nix derivation the PATH is completely empty, so
functions like `exec.Command("bash")` don't work. To make dealing with
this easier, add a helper function that looks for an environment
variable named after the command and returns `$cmd/bin/cmd` (e.g.,
`bash` becomes `$bash/bin/bash`). This will automatically find
build-time dependencies that are added as attributes to the derivation.
savil
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running inside a Nix derivation the PATH is completely empty, so functions like
exec.Command("bash")don't work. To make dealing with this easier, add a helper function that looks for an environment variable named after the command and returns$cmd/bin/cmd(e.g.,bashbecomes$bash/bin/bash). This will automatically find build-time dependencies that are added as attributes to the derivation.