Skip to content

Conversation

mohsenari
Copy link
Collaborator

Summary

Added vscode extension for devbox under vscode-extension/.
It shows 15 file changes but most of the implementation is in extension.ts and package.json files.

How was it tested?

  • cd vscode-extension/
  • yarn install
  • open vscode in this directory
  • press F5 or press run in the run & debug section from the sidebar in vscode
  • in the new opened vscode window, open a devbox project then open the vscode integrated Terminal
  • confirm terminal runs devbox shell automatically

@mohsenari mohsenari requested review from loreto and LucilleH October 20, 2022 19:16
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the same license as Jetpack License in devbox?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but in the extension marketplace, there needs to be a license file at the root level of the extension project. That's why I made a separate file here.

Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@@ -0,0 +1,17 @@
{
"compilerOptions": {
"module": "commonjs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this by convention for vscode extension? Generally I use es6 instead of commonjs. But it doesn't matter much really.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was preset as I followed the steps on the extension guide. So I'd rather leave it as is.

/* Additional Checks */
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
// "noUnusedParameters": true, /* Report errors on unused parameters. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want those checks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, for now I left it as default values as the official guide for vscode extensions.

@mohsenari mohsenari merged commit 00ed2eb into main Oct 20, 2022
@mohsenari mohsenari deleted the mohsen--vscode-extension branch October 20, 2022 23:24
@mohsenari
Copy link
Collaborator Author

Linking somewhat related issues:
#209
#226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants