Skip to content

Conversation

savil
Copy link
Collaborator

@savil savil commented Nov 7, 2022

Summary

  1. The Feature Flag library should respect the value of the env-var, whether ON or OFF.
  2. Turn on the default value of the nixpkgs version FF.

How was it tested?

For change #1: respecting the env-var:

> DEVBOX_FEATURE_NIXPKG_VERSION=0 DEVBOX_DEBUG=1 devbox shell
> git status
# saw no changes to devbox.json as expected

For change #2: enabling the nixpkgs version

> devbox shell
> git status
# saw changes to devbox.json that adds the default commit hash

Copy link
Collaborator Author

savil commented Nov 7, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested a review from LucilleH November 7, 2022 21:37
Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@savil savil merged commit a30c2f2 into main Nov 8, 2022
@savil savil deleted the savil/enable-nixpkg-version branch November 8, 2022 04:10
@savil
Copy link
Collaborator Author

savil commented Nov 8, 2022

from @Lagoja :

verified the feature, managed to downgrade my version of elixir in a project using: https://lazamar.co.uk/nix-versions/?package=elixir&version=1.8.2&fullName=elixir-1.[…]5d5da4abb74f0dd76967044735c70e94c5af1&channel=nixpkgs-unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants