Track panics in sentry #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucilleH
force-pushed
the
lucille--shell-fish
branch
from
9f985e7 to
59e43d1
Compare
savil
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
nice!
Could we move sentry.Init to before command-execution in the sshshim code too: https://github.com/jetpack-io/devbox/blob/main/internal/cloud/openssh/sshshim/command.go#L17
(would have to remove sentry.Init from the logSentry function in that file)
LucilleH
force-pushed
the
lucille--shell-fish
branch
from
809a88c to
571b47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that a lot of the shell-related functionality have
panicsand we have no idea if they are happening or not until some reports come in. This is to inform us on the panics and proactively fix issuesHow was it tested?
devbox run build
./devbox shell on invalid base shell