Auto-generate .envrc at devbox init #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsenari
commented
Jan 6, 2023
internal/impl/devbox.go
Outdated
| if !filesExist { // don't overwrite an existing .envrc | ||
| err := generate.CreateEnvrc(tmplFS, dir) | ||
| if err != nil { | ||
| return false, errors.WithStack(err) |
There was a problem hiding this comment.
Should we ignore this? if .envrc creation fails, should we just move forward with devbox init flow and not interrupt?
There was a problem hiding this comment.
yeah, you can print a warning via debug.Log but probably not worth concerning a user about.
savil
approved these changes
Jan 7, 2023
Signed-off-by: mohsenari <mohsenari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Title says it
This is step 2 out of 4 for simplifying direnv integration with devbox
How was it tested?
devbox init.envrcfile is created