Skip to content

Conversation

savil
Copy link
Collaborator

@savil savil commented Jan 23, 2023

Summary

For devbox shell, we do NOT return an exit error if a user's shell command had
returned a non-zero exit code. devbox cloud shell inherits this behavior.

For devbox run, we do return an error for the above scenario (as before).

How was it tested?

scenarios:

  • verified local devbox shell
  • cloud: custom built a binary and deployed a machine. Observed that we no longer
    return an error if the user's last command was errant:

cloud shell output:

(cloud) ❯ which foobar

(cloud) ❯ exit
exit
Shared connection to 9080557a662987.vm.devbox-vms.internal closed.

❯ echo "$?"
0

Copy link
Collaborator Author

savil commented Jan 23, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested review from LucilleH and gcurtis January 23, 2023 23:18
Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, now I understand why we return nil prior to these changes

@savil savil merged commit 4f5db5e into main Jan 24, 2023
@savil savil deleted the savil/shell-error-code branch January 24, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants