[devbox] Add version detection to the go planner #49
Conversation
|
Awesome! It's worth noting that if a user adds an additional go package(with a version that's different from the one in the go.mod file) to their devbox config, they will still run into a build error complaining about the conflict. IIRC, Nix has a way to set which package has priority so you can install multiple versions of a package so it may be worth adding a step to the build to handle that. Not really sure how often someone will want multiple versions of a language in a devbox container but since it's a valid option it's probably worth having something in place to either handle it or warn the user when the scenario is detected. |
| // Should we be throwing an error instead, if we don't have a nix package | ||
| // for the specified version of go? |
There was a problem hiding this comment.
Might be a good idea if we don't have a newer enough version.
There was a problem hiding this comment.
Decided to keep: as long as we're updating this to always have the latest version of go, it should work ok. Later we can parse the versions and compare, so we only give the error if the version is greater.
planner/go_planner.go
Outdated
| } | ||
| } | ||
|
|
||
| func getVersion(gomodPath string) string { |
There was a problem hiding this comment.
I think getVersion is kind of vague because this lives in the same package as other planners. Maybe parseGoVersion?
There was a problem hiding this comment.
Can also be a method on GoPlanner
python will have similar
There was a problem hiding this comment.
Changing to parseGoVersion as requested.
Summary
Add version detection to the go planner based on the contents of
go.mod. When we don't have a corresponding package innixpkgswe default to1.19How was it tested?
Compiled and ran against local project.