devbox run can run arbitrary commands #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsenari
reviewed
Jan 24, 2023
| if script == "" || !slices.Contains(scripts, script) { | ||
| return errors.Errorf("no script found with name \"%s\". "+ | ||
| "Here's a list of the existing scripts in devbox.json: %v", script, scripts) | ||
| } |
There was a problem hiding this comment.
What happens when a user has a script in their devbox.json named "ls" and they run devbox run ls ?
Does the script alias take precedent over the command ls? or vice versa?
There was a problem hiding this comment.
The script takes precedence
mohsenari
requested changes
Jan 24, 2023
internal/nix/run.go
Outdated
| return errors.New("attempted to run script but did not specify script name") | ||
| func RunScript(nixShellFilePath string, projectDir string, cmdWithArgs string, additionalEnv []string) error { | ||
| if cmdWithArgs == "" { | ||
| return errors.New("attempted to run a command but gave an empty command") |
There was a problem hiding this comment.
it can be both a command or a script right? so can we say "attempted to run a command or a script but gave an empty one?" or something like this?
There was a problem hiding this comment.
Sure. I was assuming that a "command" can be a script, but I can change the wording to make it clearer.
|
PTAL |
ipince
force-pushed
the
rodrigo/run-cmd
branch
from
3620865 to
21d07d9
Compare
mohsenari
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?