[bugfix] Arbitrary commands should also run init and plugin hooks #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jan 28, 2023
| } | ||
| cmdWithArgs = []string{d.scriptPath(d.scriptFilename(arbitraryCmdFilename))} | ||
| // TODO: move this env var elsewhere. I will move all the env stuff into a single ComputeEnv() function. | ||
| pluginEnv = append(pluginEnv, fmt.Sprintf("DEVBOX_RUN_CMD=%s", strings.Join(append([]string{cmdName}, cmdArgs...), " "))) |
There was a problem hiding this comment.
is pluginEnv the environment generated after the init-hooks and plugin-hooks have run?
There was a problem hiding this comment.
no, the stuff in pluginEnv comes first. do you have a concern related to ordering?
ipince
force-pushed
the
rodrigo/run-cmd-hooks
branch
from
ebc18d2 to
c896751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this fix, if your had
export FOO=barin your init hook, and you had a script"foo": "echo $FOO", then these two commands would have different results:The second invocation should also return
bar. This change makes it so.Note that the implementation is a bit odd. I left a comment explaining why it's so.
How was it tested?
Ran the commands in the description above and they both returned the same.