cloud: clean up mutagen sync ssh commands #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `openssh` package where possible when executing the SSH commands for setting the mutagen sync status. This provides better logging when commands fail. Also rename `openssh.Client` to `Cmd` to better reflect that we're calling an external process.
mikeland73
approved these changes
Jan 30, 2023
Signed-off-by: Greg Curtis <greg.curtis@jetpack.io>
gcurtis
added a commit
that referenced
this pull request
Jan 31, 2023
Use the `openssh` package where possible when executing the SSH commands for setting the mutagen sync status. This provides better logging when commands fail. Also rename `openssh.Client` to `Cmd` to better reflect that we're calling an external process.
mikeland73
pushed a commit
that referenced
this pull request
Feb 1, 2023
Use the `openssh` package where possible when executing the SSH commands for setting the mutagen sync status. This provides better logging when commands fail. Also rename `openssh.Client` to `Cmd` to better reflect that we're calling an external process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
opensshpackage where possible when executing the SSH commands for setting the mutagen sync status. This provides better logging when commands fail.Also rename
openssh.ClienttoCmdto better reflect that we're calling an external process.