Create unified function for nix env computation #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
reviewed
Feb 8, 2023
| return nil | ||
| } | ||
|
|
||
| func (d *Devbox) computeNixEnv() ([]string, error) { |
There was a problem hiding this comment.
Should this be called in other places we need env? (Shell and RunScriptInNewNixShell)
There was a problem hiding this comment.
I believe that is the intention (in a future PR)
savil
approved these changes
Feb 8, 2023
| return nil | ||
| } | ||
|
|
||
| func (d *Devbox) computeNixEnv() ([]string, error) { |
There was a problem hiding this comment.
I believe that is the intention (in a future PR)
internal/impl/devbox.go
Outdated
|
|
||
| func (d *Devbox) computeNixEnv() ([]string, error) { | ||
| nixShellFilePath := filepath.Join(d.projectDir, ".devbox/gen/shell.nix") | ||
| vaf, err := nix.PrintDevEnv(nixShellFilePath) |
There was a problem hiding this comment.
use: d.nixShellFilePath() but first please approve #584 so it can be landed :)
There was a problem hiding this comment.
oops, sorry for not seeing that earlier! merging in main and updating...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This mainly refactors the env computation from
nix.Run()into a place where it can be reused for both shell, run, and direnv integration. This should be a functional no-op.How was it tested?
./devbox run -- echo '$PATH'and other env vars