Add virtenv path and nix profile path to computed nix path #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Feb 10, 2023
| // 1. Start with the PATH as defined by nix (through nix print-dev-env). | ||
| // 2. TODO: Clean the host PATH of any nix paths. | ||
| // 3. Append the cleaned host PATH (tradeoff between reproducibility and ease of use). | ||
| // 4. Prepend the devbox-managed nix profile path (which is needed to support devbox add inside shell--can we do without it?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This brings the
computeNixEnvPATH handling to (almost) parity withdevbox shell. I might remove the virtenv path after confirming we don't need it.How was it tested?
Compared
devbox shellPATH with the PATH I get indevbox shellordevbox runwhen I haveNIXLESS_SHELLorSTRICT_RUNenabled, respectively.