[flakes] enable native nixpkgs download progress output #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
ipince
approved these changes
Feb 10, 2023
|
👍 We can probably remove |
|
@mikeland86 I need the tab-indentation that it does, but could remove the filtering for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nix flakes prefetchhas a native progress indicator in its output. However,it seems that using the
nixPackagesInstallWriterwould result in it not displaying.Perhaps because of the tab indentation? Not entirely sure.
This PR uses the regular
io.writerinstead of the customnixPackagesInstallWriterfor the nixpkgs prefetch
How was it tested?
devbox shellobserved the progess indicator