[global] Implement simple global pull #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Feb 15, 2023
| func globalPullCmd() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "pull <file> | <url>", | ||
| Short: "Pulls a global config from a file or URL", |
There was a problem hiding this comment.
it seems that url requires the scheme. That's non-obvious but very reasonable, so could we specify an example in the Long explanation?
|
|
||
| func (d *Devbox) PullGlobal(path string) error { | ||
| u, err := url.Parse(path) | ||
| if err == nil && u.Scheme != "" { |
There was a problem hiding this comment.
scheme requirement is here (ref. previous comment above)
| return "", err | ||
| } | ||
| nixDirPath := filepath.Join(configPath, "nix") | ||
| _ = os.MkdirAll(nixDirPath, 0755) |
mikeland73
added a commit
that referenced
this pull request
Feb 15, 2023
## Summary This is stacked on #630 This moves global data to XDG_DATA_HOME or `~/.local/share` * The devbox.json is stored in `~/.local/share/devbox/global/default/devbox.json` * The nix profile is in `~/.local/share/devbox/global/default/nix-profile` * the bin path is `~/.local/share/devbox/global/current/nix-profile/bin` ## How was it tested? `devbox global add hello`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This "pulls" a global config either from a local path or URL. It merges the packages into the existing config.
How was it tested?