[PHP] Add PHP shell support #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Sep 5, 2022
loreto
reviewed
Sep 6, 2022
README.md
Outdated
| @@ -142,6 +142,10 @@ Devbox currently detects the following languages: | |||
| - Go | |||
| - Python (Poetry) | |||
|
|
|||
| Shell only support: | |||
There was a problem hiding this comment.
Technically we let you create a shell for any language, you just need to declare the packages you need in devbox.json. So I'm slightly worried that by phrasing these as "shell-only" people will interpret it as, languages not in this list are not supported at all.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #64
How was it tested?