Skip to content

[devcontainer] Fixed bug on multiple python extensions listed in devcontainer #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023
+11 −1
Merged

[devcontainer] Fixed bug on multiple python extensions listed in devcontainer #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion internal/boxcli/generate/devcontainer_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ import (
"html/template"
"os"
"path/filepath"
"regexp"
"strings"

"github.com/pkg/errors"
"go.jetpack.io/devbox/internal/debug"
)

type devcontainerObject struct {
Expand Down Expand Up @@ -114,11 +116,19 @@ func getDevcontainerContent(pkgs []string) *devcontainerObject {
RemoteUser: "devbox",
}

// match only python3 or python3xx as package names
py3pattern, err := regexp.Compile(`(python3)$|(python3[0-9]{1,2})$`)
if err != nil {
debug.Log("Failed to compile regex")
return nil
}
for _, pkg := range pkgs {
if strings.Contains(pkg, "python3") {
if py3pattern.MatchString(pkg) {
// Setup python3 interpreter path to devbox in the container
devcontainerContent.Customizations.Vscode.Settings = map[string]any{
"python.defaultInterpreterPath": "/code/.devbox/nix/profile/default/bin/python3",
}
// add python extension if a python3 package is installed
devcontainerContent.Customizations.Vscode.Extensions =
append(devcontainerContent.Customizations.Vscode.Extensions, "ms-python.python")
}
Expand Down