Skip to content

Shellenv prepends to original path, not current path #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Shellenv prepends to original path, not current path #730

merged 1 commit into from
Mar 7, 2023

Conversation

ipince
Copy link
Contributor

@ipince ipince commented Mar 7, 2023

Summary

Fixes #687

How was it tested?

echo $PATH
devbox shell
hello # fails
devbox add hello
eval $(devbox shellenv)
hello # ok!
devbox rm hello
eval $(devbox shellenv)
hello # fails

@ipince ipince requested review from savil and mohsenari March 7, 2023 22:00
@ipince ipince merged commit af9408e into main Mar 7, 2023
@ipince ipince deleted the rodrigo/fix-shellenv branch March 7, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohsenari mohsenari mohsenari approved these changes

@savil savil Awaiting requested review from savil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: devbox shellenv shouldn't prepend to existing path
2 participants
@ipince @mohsenari