Skip to content

plansdk: get cloud cache from environment #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

plansdk: get cloud cache from environment #734

merged 1 commit into from
Mar 8, 2023

Conversation

gcurtis
Copy link
Collaborator

@gcurtis gcurtis commented Mar 8, 2023

Remove the hardcoded IP and instead get the base URL from the DEVBOX_CACHE environment variable.

@gcurtis
plansdk: get cloud cache from environment
5763cfa 
Remove the hardcoded IP and instead get the base URL from the
`DEVBOX_CACHE` environment variable.
@gcurtis gcurtis requested review from loreto, savil and LucilleH March 8, 2023 15:19
loreto
loreto approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcurtis gcurtis merged commit bc7b7e1 into main Mar 8, 2023
@gcurtis gcurtis deleted the gcurtis/new-cache branch March 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loreto loreto loreto approved these changes

@savil savil Awaiting requested review from savil

@LucilleH LucilleH Awaiting requested review from LucilleH

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcurtis @loreto