Revert "Plugin Contributing Guide (#611)" #742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f7c249e.
|
Closing in favor of #743 |
ipince
added a commit
that referenced
this pull request
Mar 10, 2023
## Summary TSIA. See #742 for context. ## How was it tested? Ran `devbox shell`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f7c249e.
Summary
Build is broken with:
I haven't gotten to the bottom of it, but I know it's this commit (based on binary search over commits). I think it's because the README contains
{{ package }}, and somewhere our Go code is interpreting the README as a go-template (maybe some code is walking down a directory?) and it fails to compile the template becausepackageis not defined.How was it tested?
Ran
devbox shellsuccessfully.