ci: use DeterminateSystems Nix installer #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this can help fix the flaky installer bugs on macOS.
mikeland73
approved these changes
Mar 13, 2023
|
Yeah, I wanted to try it out in CI first to see how it goes. |
mohsenari
reviewed
Mar 13, 2023
| uses: DeterminateSystems/nix-installer-action@v1 | ||
| with: | ||
| logger: pretty | ||
| nix-build-user-count: 4 |
There was a problem hiding this comment.
is there a reason behind putting 4 here or it's just to have a multi-user mode
There was a problem hiding this comment.
It defaults to 32, but creating 32 user accounts on macOS can be slow so I reduced it to 4. I don't think it should affect things too much since none of our jobs should be building from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this can help fix the flaky installer bugs on macOS. Also remove a really slow integration test.