[services] Improve auto-port forward and proxy #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Mar 17, 2023
Comment on lines
+169
to
+189
| for _, service := range services { | ||
| if port, _ := service.Port(); port != "" { | ||
| color.New(color.FgHiGreen).Fprintf( | ||
| w, | ||
| "To access %s on this vm use: %s-%s.svc.devbox.sh\n", | ||
| service.Name, | ||
| hostname, | ||
| port, | ||
| ) | ||
| } else { | ||
| printGeneric = true | ||
| } | ||
| } | ||
|
|
||
| if printGeneric { | ||
| color.New(color.FgHiGreen).Fprintf( | ||
| w, | ||
| "To access other services on this vm use: %s-<port>.svc.devbox.sh\n", | ||
| hostname, | ||
| ) | ||
| } |
There was a problem hiding this comment.
what if I have 3 services, but only one has a port, then this will print for just the one having-port-service. That seems problematic because users will worry about how to access the other-non-explicity-port-services.
Could we improve this to:
To access <having-port-service> on this vm use: ....
To access other services on this vm use: .....
There was a problem hiding this comment.
I think the current behavior is what you are describing. If at least one service doesn't have a declared port, printGeneric will be true so we print the last message.
There was a problem hiding this comment.
oh you are right. booleans are hard!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves:
How was it tested?
builds