Skip to content

Conversation

mikeland73
Copy link
Contributor

Summary

  • Uses php dev server
  • looks for public/index.php

How was it tested?

  • devbox build examples/php
  • unit test

Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loreto
Copy link
Contributor

loreto commented Sep 8, 2022

It says you're merging into landau/improve-python instead of main?

Base automatically changed from landau/improve-python to main September 8, 2022 19:40
@mikeland73
Copy link
Contributor Author

It was stacked so I can leverage new test code

@mikeland73 mikeland73 merged commit 7828042 into main Sep 8, 2022
@mikeland73 mikeland73 deleted the landau/php branch September 8, 2022 19:41
@Lagoja Lagoja added this to the 0.0.5 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants