Skip to content

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Apr 11, 2023

Summary

This change allows packages to be specified like so:

 "packages": [
    "github:nixos/nixpkgs/5233fd2ba76a3accb5aaa999c00509a11fd0793c#hello",
    "github:F1bonacc1/process-compose"
  ],

It works similar to local flakes.

We use nix search to determine the attribute path. If zero or more than 1 are available, we show error.

Other improvements:

  • Prevent flakes from being listed more than once in inputs
  • Use search instead of show for faster validation of outputs.

TODO:

  • Found bug when doing devbox rm. ProfileListIndex not working correctly for defaultPackage

TODO: (in follow up):

  • Optimize by caching nix search

How was it tested?

  • example
  • unit tests

@mikeland73 mikeland73 requested review from gcurtis, savil and ipince April 11, 2023 00:42
@mikeland73 mikeland73 force-pushed the landau/remote branch 2 times, most recently from b196cb8 to bfac4ec Compare April 11, 2023 18:26
@mikeland73
Copy link
Contributor Author

@gcurtis this changed a little bit, can you PTAL? Thanks!

@mikeland73 mikeland73 merged commit 54d1db0 into main Apr 11, 2023
@mikeland73 mikeland73 deleted the landau/remote branch April 11, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants