[direnv] add quotations around devbox-shellenv-init-hook call #913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Lagoja is reporting an error of the form:
In our generated code we have
eval $(devbox shellenv --init-hook)
.The error is occuring because bash is executing the
devbox shellenv --init-hook
priorto doing the eval. Any
$(<bash command>)
within the output ofdevbox shellenv
will also be eagerly evaluated (via bash command substituion) prior to the
final
eval
.With the change: we add quotations around the
$(devbox shellenv --init-hook)
sothat the
eval
operation will execute thedevbox shellenv --init-hook
. Andeval
each line in the output as it goes.
This way, a line in our init-hook like
export GOROOT="(go env GOROOT)"
will have access to thego
binary prior to
go env GOROOT
being executed (a prior line fromdevbox shellenv
adds thego
binary toPATH
).How was it tested?
go
from my zshrcPATH
.rm .envrc
anddirenv revoke .
to reset.devbox generate direnv
anddirenv allow .
cd ..
to exit directory andcd devbox
to enter directoryBEFORE: saw error above
AFTER: no error seen