Skip to content

[direnv] change default hooks for shell --print-env #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2023
Merged

[direnv] change default hooks for shell --print-env #928

merged 2 commits into from
Apr 19, 2023

Conversation

mohsenari
Copy link
Collaborator

Summary

title says it

How was it tested?

  • devbox shell --print-env
  • confirm output does not contain . /path/to/.hooks.sh

mikeland73
mikeland73 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment saying init hooks are not compatible with old .envrc

@mohsenari mohsenari enabled auto-merge (squash) April 19, 2023 18:08
@mohsenari mohsenari merged commit 9386506 into main Apr 19, 2023
@mohsenari mohsenari deleted the mohsen--fix-direnv-issue branch April 19, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohsenari @mikeland73