nix: allow users to set shell startup hooks #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `shell.init_hook` field to devbox.json which can contain arbitrary
commands to run at shell startup.
{
"packages": ["go"],
"shell": {
"init_hook": "echo hello from a hook!"
}
}
This change also merges the `shell` package into `nix`, making it
clearer that it handles Nix shells specifically. The `nix.Shell`
function is replaced by the `nix.Shell` struct, which does everything
that the `shell.Shell` struct did.
The new API looks something like:
sh, err := nix.DetectShell()
sh.UserInitHook = cfg.Shell.InitHook
sh.Run(nixPath)
Finally, we now build the devbox shellrc with a template since it was
getting a bit complex.
gcurtis
force-pushed
the
gcurtis/hooks
branch
from
d0c8393 to
6d8981e
Compare
|
Obviously also open to suggestions on how the |
Lagoja
reviewed
Sep 8, 2022
loreto
approved these changes
Sep 9, 2022
This is to make sure we don't try to use a partially-read file.
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
shell.init_hookfield to devbox.json which can contain arbitrary commands to run at shell startup.This change also merges the
shellpackage intonix, making it clearer that it handles Nix shells specifically. Thenix.Shellfunction is replaced by thenix.Shellstruct, which does everything that theshell.Shellstruct did.The new API looks something like:
Finally, we now build the devbox shellrc with a template since it was getting a bit complex.
How was it tested?
Adding a hook and running a shell.